Dynamic translation unification #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the QString compatible UnicodeMod and its `arg` method with plain Qt translations and python formatting.
Simple search&replace across the `*.ts` files to turn any `%[0-9]` into
`{}`, plus some manual fixes to prevent changed whitespace from
obsoleting translations.
Replaced the `%` operator with `str.format`, so there is exactly one way we do dynamic translations.
Simple search&replace across the `*.ts` files to turn any `%[sd]` into
`{}`, plus some manual fixes to prevent changed whitespace from
obsoleting translations.
Since all translations were migrated ealier, this only changes the lines. No translations are added or removed. $ ./update_translations.py de
$ lrelease translations/*.ts
$ pyrcc5 puddlestuff/resource.qrc -o puddlestuff/resource.py
sandrotosi
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UnicodeMod
Replaced the QString compatible UnicodeMod and its
argmethod with plain Qt translations and python formatting.Migrate UnicodeMod translations
Simple search&replace across the
*.tsfiles to turn any%[0-9]placeholders into{}, plus some manual fixes to prevent changed whitespace from obsoleting translations.Remove printf-style formatting from translations
Replaced the
%operator withstr.format, so there is exactly one way we do dynamic translations.Migrate printf-style translations
Simple search&replace across the
*.tsfiles to turn any%[sd]placeholders into{}, plus some manual fixes to prevent changed whitespace from obsoleting translations.Update translations
Since all translations were migrated ealier, this only changes the lines. No translations are added or removed.
$ ./update_translations.py deCompile translations
$ lrelease translations/*.tsRegenerate resource.py
$ pyrcc5 puddlestuff/resource.qrc -o puddlestuff/resource.py