Fix iTunes stuff in MP4 and ID3 #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they are integer fields, they require special convertion. Might as well properly map them and use human-understandable names.
Nothing itunes-specific about the TSO2 frame, which is also not albumsort but albumartistsort. So rename it and use the proper name.
corubba
force-pushed
the
bugfix/itunes
branch
from
0b0c560
to
42a7d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mp4 itunes id fields
Because they are integer fields, they require special convertion. Might as well properly map them and use human-understandable names.
Fixes #850
Consistently use albumartistsortorder
Nothing itunes-specific about the TSO2 frame, which is also not albumsort but albumartistsort. So rename it and use the proper name (which is already used for mp4 and wma).
Fixes #284