for loops are now generated inline rather than in an IIFE #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -561,7 +562,8 @@ Lexer.prototype = { | |||
| if (captures = /^(?:- *)?(?:each|for) +([a-zA-Z_$][\w$]*)(?: *, *([a-zA-Z_$][\w$]*))? * in *([^\n]+)/.exec(this.input)) { | |||
| this.consume(captures[0].length); | |||
| var tok = this.tok('each', captures[1]); | |||
| tok.key = captures[2] || '$index'; | |||
| tok.key = captures[2] || '$$i' + this.eachCount; | |||
| this.eachCount++; | |||
There was a problem hiding this comment.
this is split into two lines on purpose for readability
|
This is great, but definitely a breaking change. Could you make this pull request against jade-code-gen project as well. |
|
Moved variable name generation out of the lexer. |
|
Unfortunately I still don't consider this backwards compatible because:
I'm very excited for getting this done in the 2.0.0 release though :) |
|
Now that we have started landing breaking changes in master, can we merge this or should it go straight into jade-code-gen? |
|
It needs to go straight into jade-code-gen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This again improves performance a little bit (part of #1975).
The first change is to rename
$indexto$$iN, where N is the Nth for loop. The PR assumes this is safe. It also assumes it is safe to use variables that look likeKEY__objandKEY__l, where KEY is either$$iNor the KEY provided by the user.