-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Imagine #35
Comments
Good idea I like Imagine project, but we have few calls to GD ... I'm not convinced... dunno is my response :) |
I know maybe it's too much for the few GD calls, but ImageCreatorTest is filesystem based, and thus it's an integration test. ImageCreator should have a real unit test, but with explicit gd extension calls it's very hard to unit test it. With Imagine as an injected dependency instead, it would be very easy, with very little overhead. My 2 cents! |
I think that @giorrrgio's idea is good and maybe we have also to mock the file system with https://github.com/mikey179/vfsStream |
Take a look also to https://github.com/KnpLabs/Gaufrette for FS abstraction :) |
good idea... On Thu, Jun 6, 2013 at 10:55 AM, Stefano Sala notifications@github.comwrote:
liuggio_______________ /|_ We reject kings, presidents and voting. |
@stewe do you have time to do some experiments? |
:) thanks to @stewe we now (3 months ago) have imagine library.. |
Congrats :) |
Improving OOP, we could move from direct gd ext calls to avalanche123/Imagine classes.
The text was updated successfully, but these errors were encountered: