Switch to Imagine

[giorrrgio]

Improving OOP, we could move from direct gd ext calls to avalanche123/Imagine classes.

[liuggio]

Good idea I like Imagine project, but we have few calls to GD ... I'm not convinced... dunno is my response :)
how it could improve our OOP project?
@toretto460, @leopro what do you think?

[giorrrgio]

I know maybe it's too much for the few GD calls, but ImageCreatorTest is filesystem based, and thus it's an integration test. ImageCreator should have a real unit test, but with explicit gd extension calls it's very hard to unit test it. With Imagine as an injected dependency instead, it would be very easy, with very little overhead. My 2 cents!

[leopro]

I think that @giorrrgio's idea is good and maybe we have also to mock the file system with https://github.com/mikey179/vfsStream

[stefanosala]

Take a look also to https://github.com/KnpLabs/Gaufrette for FS abstraction :)

[liuggio]

good idea...
with the profiler the FS is really fast is nanosecs, the bottlen. is
packagist API of course

On Thu, Jun 6, 2013 at 10:55 AM, Stefano Sala notifications@github.comwrote:

Take a look also to https://github.com/KnpLabs/Gaufrette for FS
abstraction :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-19032513
.

liuggio_______________

/|_ We reject kings, presidents and voting.
/o ) / We believe in rough consensus
) v _/\ and running code (I.E.T.F. credo)

---

[liuggio]

@stewe do you have time to do some experiments?

[liuggio]

:) thanks to @stewe we now (3 months ago) have imagine library..

[odino]

Congrats :)