Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel image reverts to first file of resource when form is loaded #448

Closed
hackartisan opened this issue Nov 27, 2018 · 2 comments · Fixed by #456
Closed

Carousel image reverts to first file of resource when form is loaded #448

hackartisan opened this issue Nov 27, 2018 · 2 comments · Fixed by #456
Assignees
@hackartisan
Labels
bug

Comments

@hackartisan
Copy link
Member

to replicate:
edit an about page. Add a multi-page resource to a carousel. select a page within that resource (not the first page). save the about page. edit the about page again. Now the first page of the resource is selected for the carousel. You cannot save any other change to the about page without reverting that image selection.
@eliotjordan eliotjordan mentioned this issue Nov 27, 2018
Closed
@hackartisan hackartisan self-assigned this Nov 27, 2018
@hackartisan hackartisan changed the title Selecting a page from a resource on a carousel does not persist to next time the form is loaded Carousel image reverts to first file of resource when form is loaded Nov 27, 2018
@hackartisan
Copy link
Member Author

hackartisan commented Nov 27, 2018 •
edited
Loading

could be related to #182, where joyce describes the same "reverting to the first image" behavior

@hackartisan
Copy link
Member Author

the problem is that spotlight depends on an image id in the manifest. the iiif spec (https://iiif.io/api/presentation/2.1/#image-resources) says this id is optional, so it's not implemented by figgy. created pulibrary/figgy#2246

hackartisan added a commit that referenced this issue Nov 29, 2018
@hackartisan
Add failing test for #448
95c61aa
hackartisan added a commit that referenced this issue Nov 29, 2018
@hackartisan
Add failing test for #448
ab305d4
hackartisan added a commit that referenced this issue Nov 29, 2018
@hackartisan
Add failing test for #448
1594214
@hackartisan hackartisan mentioned this issue Nov 29, 2018
Merged
escowles added a commit that referenced this issue Nov 30, 2018
@escowles
Merge pull request #456 from pulibrary/issue/448-test
3263a41 
Adds a test for #448 and shows it pass with updated fixture data from pulibrary/figgy#2249
@escowles escowles removed the review label Nov 30, 2018
hackartisan added a commit that referenced this issue Nov 30, 2018
@hackartisan
Revert "Add failing test for #448"
1cd7eb9 
This reverts commit 1594214.
escowles added a commit that referenced this issue Nov 30, 2018
@escowles
Merge pull request #458 from pulibrary/revert-stuff
f1f55f7 
Revert the new test for #448
@hackartisan hackartisan mentioned this issue Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackartisan hackartisan

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@hackartisan @escowles