Merge pull request #2542 from pulibrary/graphql_resource_thumbnail

Handle thumbnail returning nil in GraphQL
pulibrary · Feb 6, 2019 · c378fca · c378fca
2 parents 58e0c1b + 2f7ffe6
commit c378fca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/graphql/types/resource.rb b/app/graphql/types/resource.rb
@@ -59,7 +59,7 @@ def helper
   end
 
   def thumbnail
-    return if object.try(:thumbnail_id).blank? || thumbnail_resource.blank?
+    return if object.try(:thumbnail_id).blank? || thumbnail_resource.blank? || helper.figgy_thumbnail_path(thumbnail_resource).blank?
     {
       id: thumbnail_resource.id.to_s,
       thumbnail_url: helper.figgy_thumbnail_path(thumbnail_resource),

diff --git a/spec/graphql/types/scanned_resource_type_spec.rb b/spec/graphql/types/scanned_resource_type_spec.rb
@@ -73,6 +73,10 @@
           id: file_set.id.to_s
         )
       end
+      it "returns nil if the helper fails to return a thumbnail path" do
+        allow(type.helper).to receive(:figgy_thumbnail_path).and_return(nil)
+        expect(type.thumbnail).to be_nil
+      end
     end
     context "when a bad thumbnail is set" do
       let(:scanned_resource) do