Merge pull request #85 from pulibrary/relax-code-validations

Relax code format validation

app/models/concerns/locations/coded.rb

@@ -6,8 +6,6 @@ module Coded
       friendly_id :code
       validates :code, presence: true
       validates :code, uniqueness: true
-      validates_format_of :code, with: /\A[a-z][a-z0-9]{0,13}\Z/,
-        message: 'must be at least one character, all lowercase letters or numbers, and may not start with a number'
     end
   end
 end

spec/models/locations/library_spec.rb

@@ -25,17 +25,20 @@ module Locations
       end
 
       describe 'code must follow naming conventions' do
-        it 'may not have spaces' do
+        # TODO: Update this test when gem is updated.
+        xit 'may not have spaces' do
           expect {
             FactoryGirl.create(:library, code: 'my code')
           }.to raise_error ActiveRecord::RecordInvalid
         end
-        it 'may not have capital letters' do
+        # TODO: Update this test when gem is updated.
+        xit 'may not have capital letters' do
           expect {
             FactoryGirl.create(:library, code: 'myCode')
           }.to raise_error ActiveRecord::RecordInvalid
         end
-        it 'may not start with a number' do
+        # TODO: Update this test when gem is updated.
+        xit 'may not start with a number' do
           expect {
             FactoryGirl.create(:library, code: '42mycode')
           }.to raise_error ActiveRecord::RecordInvalid
@@ -60,7 +63,8 @@ module Locations
             FactoryGirl.create(:library, code: 'cotsenresearch')
           }.to_not raise_error
         end
-        it 'code may not be more than 14 characters' do
+        # TODO: Update this test when gem is updated.
+        xit 'code may not be more than 14 characters' do
           expect {
             FactoryGirl.create(:library, code: 'thiscodeistooloong')
           }.to raise_error ActiveRecord::RecordInvalid