Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Relax code format validation #85

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Relax code format validation #85

merged 1 commit into from
Jan 21, 2021

Conversation

eliotjordan
Copy link
Member

Alma codes will have special characters and might have uppercase letters.

Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am tempted to say let's update the validation to match new expectations. But since it will be coming straight from the alma API it's probably not messing with.

The failing tests are

Do you want to comment those out with a note so that if / when we get this code up and running again we know they aren't expected to pass?

@eliotjordan
Copy link
Member Author

@hackartisan I updated with your suggestions.

@hackartisan hackartisan merged commit 8c6fe6e into master Jan 21, 2021
@eliotjordan eliotjordan deleted the relax-code-validations branch January 21, 2021 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants