Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow search results to render when 856 is missing #348

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

tampakis
Copy link
Contributor

@tampakis tampakis commented Dec 2, 2015

Advances #346

@kevinreiss
Copy link
Member

👍

title: 'Electronic Access')
info << links.shift.html_safe
if links.empty?
info << content_tag(:span, 'LINK MISSING', class: 'label label-danger',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tampakis If we are rendering something with the value "Link Missing" should we be logging this somewhere so it can be corrected by cataloging. I'm assuming that "Link Missing" is an error. Is that something we could do when records are ingested via traject?

kevinreiss added a commit that referenced this pull request Dec 3, 2015
allow search results to render when 856 is missing
@kevinreiss kevinreiss merged commit 660bce2 into development Dec 3, 2015
@tampakis tampakis deleted the online_access_fix branch December 4, 2015 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants