Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search algorithm dropdown #3827

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add search algorithm dropdown #3827

merged 1 commit into from
Nov 13, 2023

Conversation

eliotjordan
Copy link
Member

@eliotjordan eliotjordan commented Nov 13, 2023

  1. Add search algorithm dropdown
  2. Implement an Orangelight::DropdownHelpTextComponent to support help text markup within the algorithm selection dropdown UI component

Closes #3748

screenshot:
Screenshot 2023-11-13 at 12 38 53 PM

@coveralls
Copy link

coveralls commented Nov 13, 2023

Coverage Status

coverage: 95.484% (+0.01%) from 95.472%
when pulling 8fc6678 on 3748-algo-switch-ui
into dedb0d0 on main.

Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
Co-authored-by: Carolyn Cole <carolyncole@users.noreply.github.com>
Co-authored-by: James R. Griffin III <jrgriffiniii@users.noreply.github.com>
Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>

Implementing the Orangelight::DropdownHelpTextComponent to support help
text markup within the algorithm selection dropdown UI component

Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Copy link
Contributor

@rladdusaw rladdusaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@rladdusaw rladdusaw merged commit 0455236 into main Nov 13, 2023
8 checks passed
@rladdusaw rladdusaw deleted the 3748-algo-switch-ui branch November 13, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement interface (frontend) for switching algorithms
3 participants