move hash inside method

pulibrary · Dec 7, 2022 · 0a2cede · 0a2cede
1 parent 374e6c8
commit 0a2cede
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/models/pdc_serialization/datacite.rb b/app/models/pdc_serialization/datacite.rb
@@ -104,13 +104,13 @@ def self.new_from_work_resource(resource)
     # rubocop: enable Metrics/MethodLength
 
     class << self
-      resource_types = Datacite::Mapping::ResourceTypeGeneral.to_a.map { |ct| [ct.value, ct] }.to_h
       def datacite_resource_type(resource_type)
+        resource_types = ::Datacite::Mapping::ResourceTypeGeneral.to_a.map { |ct| [ct.value, ct] }.to_h
         ::Datacite::Mapping::ResourceType.new(resource_type_general: resource_types[resource_type])
       end
 
-      contributor_types = Datacite::Mapping::ContributorType.to_a.map { |ct| [ct.value, ct] }.to_h
       def datacite_contributor_type(type)
+        contributor_types = ::Datacite::Mapping::ContributorType.to_a.map { |ct| [ct.value, ct] }.to_h
         contributor_types[type]
       end
 

diff --git a/spec/models/pdc_serialization/datacite_spec.rb b/spec/models/pdc_serialization/datacite_spec.rb
@@ -121,7 +121,7 @@
 
       context "resource types" do
         it "maps dataset" do
-          resource_type = described_class.datacite_resource_type("dataset")
+          resource_type = described_class.datacite_resource_type("Dataset")
           expect(resource_type.resource_type_general.value).to eq "Dataset"
         end
         it "Audiovisual" do