Updated interface in Work Edit page to allow users to add and delete files #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcorrea
commented
Mar 31, 2023
Comment on lines
-289
to
-310
|
|
||
| it "allows users to modify the order of the uploads", js: true do | ||
| expect(page).to have_content "Filename" | ||
| expect(page).to have_content "Created At" | ||
| expect(page).to have_content "Replace Upload" | ||
| expect(page).to have_content "Delete Upload" | ||
| expect(page).to have_css('.uploads-row[data-upload-key="0"]', count: 1) | ||
| expect(page).to have_css('.uploads-row[data-upload-key="1"]', count: 1) | ||
|
|
||
| source = page.find('.uploads-row[data-upload-key="0"]') | ||
| target = page.find('.uploads-row[data-upload-key="1"]') | ||
|
|
||
| # This is necessary to interact with the rendered JavaScript <table> rows | ||
| page.scroll_to(target) | ||
| sleep 1 | ||
|
|
||
| source.drag_to(target) | ||
| sleep 1 | ||
|
|
||
| dragged = page.find('.uploads-row[data-upload-key="0"]') | ||
| expect(dragged[:id]).to eq(source[:id]) | ||
| end |
There was a problem hiding this comment.
I have no idea what this test was attempting to test...but we do not allow the user to re-order the display of files so I removed it.
carolyncole
requested changes
Apr 3, 2023
There was a problem hiding this comment.
@hectorcorrea I deployed this to staging and got errors when trying to delete files.
|
@carolyncole thank you so much tip, the spaces where indeed the problem. I've updated the code to use a safe value for the id of the HTML elements (based on the full path of the name) that prevents issue with any non-alphanumeric characters in the name. |
carolyncole
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three major changes on this PR:
Closes #1021
Closes #1010
Notice that I left a few TODOs in the code that point to an (existing) issue that needs to be addressed separately (#1041)