Adds support for communities and subcommunities #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcorrea
commented
Jun 1, 2023
| @@ -153,4 +153,48 @@ def delete_permission(current_user, removed_user) | |||
| errors.add(:delete_permission, "Unauthorized") | |||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Eventually we might want to make communities and subcommunities configurable somehow, but for now we are just trying to see if this new design works for PPPL.
carolyncole
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a user to select communities and subcommunities for their datasets.
The list of communities available to select depends on the group that the dataset is linked to. This means that PRDS submissions have a different list of communities available to them than PPPL submissions. In fact, PPPL only has one community available to them, but PPPL submissions have an extra field where users can select one or more subcommunities for their dataset.
More notes and discussion about the implementation available here: https://docs.google.com/document/d/1IRy2C_NFpODDnDTPKXQMZZx0NodXb-aVhIriGax3AwU/edit#
Below are a couple of screenshots showing how the edit screen looks for a PRDS submission vs a PPPL submission:
Closes #1031 #1227 #1228