Fixes file count discrepancy #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file list. This prevents the issue where the file count displayed to the user does not match the number of files on the list. Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
|
@hectorcorrea and @leefaisonr Looking good. I'm deploying it to staging. Looks like there is one more place where ignore_directories is being utilized. |
Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
|
We've fixed the last broken test. |
carolyncole
approved these changes
Jun 5, 2024
|
Thanks @hectorcorrea & @leefaisonr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code to display empty file names and empty folders on the file list.
This prevents the issue where the file count displayed to the user does not match the number of files on the list.
We made empty files and empty folders not downloadables on the file list.
Below is an example of how these empty files/folders are displayed:
Co-authored-by: Robert-Anthony Lee-Faison leefaisonr@users.noreply.github.com
Closes #1826
Closes #1784
See also #1836