Moving the Work form fields Publisher, Publication Year, and Collection to the Curator Controlled section
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection` to the `Curator Controlled` section
jrgriffiniii
force-pushed
the
i561-jrgriffiniii-form-tab-move
branch
3 times, most recently
from
1be78f3
to
c65b4dd
Compare
mccalluc
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Looks good.
I worry a little about the duplication between _curator_controlled_display and _currator_controlled_form. Not urgent, but I wonder if it would make sense either to factor out the shared bits into partials, or to merge the two into a single partial with a little logic to handle the differences... I'll make a diff and file a follow-up issue.
(Leaving merge for you: I think that's your preference.)
|
Thank you @mccalluc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #561