Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Who should be notified that records are ready for review? #153

Closed
escowles opened this issue Nov 2, 2015 · 9 comments
Closed

Who should be notified that records are ready for review? #153

escowles opened this issue Nov 2, 2015 · 9 comments
Assignees
Labels

Comments

@escowles
Copy link
Member

escowles commented Nov 2, 2015

  • A mailing list?
  • Several users personal email addresses?
  • All users who have the reviewer role?
  • Some other option?
@escowles
Copy link
Member Author

escowles commented Dec 4, 2015

In the state diagram in #211, the following states trigger notification:

  • final_review
  • complete
  • flagged (aka needs attention)
  • takedown

@escowles
Copy link
Member Author

escowles commented Dec 7, 2015

I think the more pressing question before tackling local mail delivery in #201 is: who wants to get an email when a record is completed in staging? @joycebcat? @jpstroop? @tpendragon? Maybe we should setup a dummy account for this, so we can check to see if it actually works, without having to sign up to actually get these emails in our real accounts?

@jpstroop
Copy link
Member

jpstroop commented Dec 7, 2015

I think the question is slightly broader: who gets an email at which point(s) in the workflow, right?

@escowles
Copy link
Member Author

escowles commented Dec 7, 2015

@jpstroop Yes, you're right that we have several points in the workflow where we want to send notifications. At some point, we will also need to resolve the question of how different environments behave.

My thinking of how to approach #201 was:

  1. Enable sendmail on hydra-dev so we can send mail (this is done already, and worked for both my princeton and personal email addresses).
  2. Update plum to sendmail for sending mail, and use an email address that we don't mind dumping a bunch of messages on.

Once that's done, this issue (#153) would be a good vehicle for deciding on a more flexible system for deciding who gets notified (either a mailing list or using plum's roles). E.g., we could make roles for each workflow state (notify_pending, notify_metadata_review, etc.) and we could email all users in the appropriate role.

@jpstroop
Copy link
Member

jpstroop commented Dec 7, 2015

@kevinreiss do you know the process for getting a dummy email address?

@escowles
Copy link
Member Author

escowles commented Dec 9, 2015

I thought it would be easier to setup a dummy email address than figure out a long-term approach. But how about:

  • Creating a role for each workflow state, and notifying every user with that role when a record enters that state.

This will be very flexible, and allow admin users to manage notifications. My understanding is that it's mostly admin users who want to be notified.

@jpstroop
Copy link
Member

jpstroop commented Dec 9, 2015

Sort of related to #210

@joycebcat
Copy link
Collaborator

It is mostly admin users who want to be notified except for the use case of notifying the project initiator at the "final review" and "complete" stages.

@jpstroop
Copy link
Member

jpstroop commented Dec 9, 2015

Unless the developers are admins...which maybe we don't need to be for the production system.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants