This repository has been archived by the owner on May 14, 2022. It is now read-only.
Sending state notifications based on role membership #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm 👍 to this approach |
| @state = state | ||
|
|
||
| Role.where(name: "notify_#{state}").first_or_create.users.each do |u| | ||
| mail(to: "#{u.email}", subject: "[plum] #{@curation_concern.human_readable_type} #{curation_concern_id}: #{state}") |
There was a problem hiding this comment.
I don't know if it's a problem, but I'm moderately sure this'll send N emails. Would we rather do all of the to: in one line? Or as BCC?
There was a problem hiding this comment.
Having been on these kinds of list before, it's definitely better if I can see the other people who received the message, so that I can start a reply-all thread if I need to.
escowles
force-pushed
the
role-based-notification
branch
from
8e10d01
to
170e282
Compare
|
I've updated it to put all the addresses in the to: field of a single email. |
tpendragon
pushed a commit
that referenced
this pull request
Dec 11, 2015
Sending state notifications based on role membership
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153 and #201