Set far/near to proper values to hide the fog on component removal (a…

…framevr#2251)
pulilab · Feb 6, 2017 · 6f6d74a · 6f6d74a
1 parent ff16173
commit 6f6d74a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 80 deletions.
diff --git a/src/components/fog.js b/src/components/fog.js
diff --git a/src/components/scene/fog.js b/src/components/scene/fog.js
@@ -47,11 +47,9 @@ module.exports.Component = register('fog', {
    */
   remove: function () {
     var fog = this.el.object3D.fog;
-    if (fog) {
-      fog.density = 0;
-      fog.far = 0;
-      fog.near = 0;
-    }
+    if (!fog) { return; }
+    fog.far = 0;
+    fog.near = 0.1;
   }
 });
 

diff --git a/tests/components/scene/fog.test.js b/tests/components/scene/fog.test.js
@@ -66,14 +66,15 @@ suite('fog', function () {
       var el = this.el;
       el.removeAttribute('fog');
       assert.equal(el.object3D.fog.far, 0);
-      assert.equal(el.object3D.fog.near, 0);
+      assert.equal(el.object3D.fog.near, 0.1);
     });
 
     test('removes exp. fog when detaching fog', function () {
       var el = this.el;
       el.setAttribute('fog', 'type: exponential');
       el.removeAttribute('fog');
-      assert.equal(el.object3D.fog.density, 0);
+      assert.equal(el.object3D.fog.far, 0);
+      assert.equal(el.object3D.fog.near, 0.1);
     });
   });
 });