Some clippy assisted cleanups #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oberien
reviewed
Mar 14, 2019
oberien
reviewed
Mar 14, 2019
oberien
reviewed
Mar 14, 2019
raphlinus
approved these changes
Mar 18, 2019
| @@ -149,7 +149,7 @@ impl<'a> Borrow<str> for CowStr<'a> { | |||
| } | |||
|
|
|||
| impl<'a> CowStr<'a> { | |||
| pub fn to_string(self) -> String { | |||
| pub fn into_string(self) -> String { | |||
There was a problem hiding this comment.
Agree but note this is a semver break. It's fine if it's scooped into the 0.4 release.
Also, I'm not sure the motivation for this is golden. Looking at rust-lang/rust-clippy#23 , it used to be the case that to_string was slower, but that got fixed.
There was a problem hiding this comment.
I don't think that's the reasoning behind the lint. to_string used to be slower because it went through the fmt::Display machinery, but that's not relevant here.
The lint that triggered this change seemed to warn against to_* methods taking self by value instead of by reference, that's all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.