Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW] Floating-Point classify, division, sqrt #100

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

mp-17
Copy link
Collaborator

@mp-17 mp-17 commented Jan 19, 2022

This PR depends on #133, #142.

Add floating-point classify, division, sqrt instructions, delayed because of the FPU.
I updated the CVA6 submodule, which now points to the modified FPU, able to classify as expected.
Moreover, the bug related to the synchronization of the FPU lanes is now solved.

Changelog

Added

  • Vector floating-point classify instruction (vfclass)
  • Vector floating-point divide instructions (vfdiv, vfrdiv)
  • Vector floating-point square-root instruction (vfsqrt)

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed
  • No frequency degradation

@mp-17 mp-17 marked this pull request as ready for review January 19, 2022 16:03
@mp-17
Copy link
Collaborator Author

mp-17 commented Jan 19, 2022

Ready for review when the automated tests pass! ;-)

@mp-17 mp-17 changed the title Floating-Point class, division, sqrt Floating-Point classify, division, sqrt Jan 19, 2022
@mp-17 mp-17 linked an issue Jan 19, 2022 that may be closed by this pull request
@suehtamacv
Copy link
Contributor

Delaying the merge until the backend issues with the divider are solved.

@suehtamacv suehtamacv mentioned this pull request Jul 13, 2022
3 tasks
@suehtamacv
Copy link
Contributor

suehtamacv commented Jul 27, 2022

Any chance we can replace FPNew's divider with the new divider everyone is talking about? 😏

@mp-17
Copy link
Collaborator Author

mp-17 commented Aug 2, 2022

Any chance we can replace FPNew's divider with the new divider everyone is talking about? smirk

Indeed, it's in the pipeline! ;-)

@mp-17 mp-17 changed the title Floating-Point classify, division, sqrt [hardware] Floating-Point classify, division, sqrt Aug 4, 2022
@mp-17
Copy link
Collaborator Author

mp-17 commented Aug 7, 2022

Any chance we can replace FPNew's divider with the new divider everyone is talking about? smirk

Unluckily, it is 32-bits only :-/

@mp-17
Copy link
Collaborator Author

mp-17 commented Aug 15, 2022

Backend problems are solved now, let's merge this as soon as the tests pass ;-)

@mp-17 mp-17 force-pushed the feat/fpu/div-sqrt-class branch 2 times, most recently from 1b88336 to ece32ee Compare August 15, 2022 10:49
@mp-17 mp-17 changed the title [hardware] Floating-Point classify, division, sqrt [HW] Floating-Point classify, division, sqrt Aug 30, 2022
@mp-17 mp-17 force-pushed the feat/fpu/div-sqrt-class branch 2 times, most recently from 082feaa to baa002a Compare September 22, 2022 09:01
@mp-17
Copy link
Collaborator Author

mp-17 commented Sep 26, 2022

@suehtamacv, we can merge this now, right?

@suehtamacv suehtamacv merged commit a2f05db into main Sep 29, 2022
@suehtamacv suehtamacv deleted the feat/fpu/div-sqrt-class branch September 29, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for vector floating-point division and square-root instructions
2 participants