Fix panic when calling parents

[micprog]

In case a dependency doesn't have a manifest, the parents command panicks as it cannot read the dependencies from the manifest. This fixes the issue, simply ignoring these dependencies.

[andreaskurth]

LGTM, thanks!

[micprog]

After further testing in the hero repo I found another bug. These changes should clarify the source of the issue, either a missing manifest or the dependency not listed in the manifest, but the lock file contains it (i.e. mismatched lock file in both cases).

[andreaskurth]

Would it not be cleaner to return an early Err from the run function of the parents subcommand, instead of inserting dummy entries as in this implementation?

[micprog]

Would it not be cleaner to return an early Err from the run function of the parents subcommand, instead of inserting dummy entries as in this implementation?

I agree the dummy entries are not the cleanest solution, however I would refrain from explicitly returning errors here as it would reduce the usability of the parents command. The problem mainly arises when the Bender.yml files are out of sync with a repository making use of the checkout_dir functionality. In this case, it is possible that a bender update will add certain dependencies to the lock file that are no longer required by the checked out dependencies, resulting in a missing link. I think the most sensible solution would be to properly update the resolution if checkout_dir is used, ensuring these Bender.yml files are used for resolution instead of the upstream git dependencies. Once this is fixed, the missing links should disappear and no longer result in dummy entries, so these missing links can return errors as they should no longer be called. For now, however, I would like to keep a functionality like this (could be altered to warnings), such that the feature is still usable and does not by default result in an error, removing even the partial functionality.

[andreaskurth]

I understand and agree, thanks!

[micprog]

Added an issue #74 to track this problem, thanks for the review!