Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the nightly job #290

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fixing the nightly job #290

merged 1 commit into from
Nov 25, 2020

Conversation

daviddavis
Copy link
Contributor

[noissue]

@pulpbot
Copy link
Member

pulpbot commented Nov 19, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@daviddavis
Copy link
Contributor Author

daviddavis commented Nov 19, 2020 •
edited
Loading

This is not quite right. We need to somehow split the test steps that use the matrix from the other steps (publish docs, clients, etc).

Edit: Filed issue https://pulp.plan.io/issues/7874

@fao89
Copy link
Member

fao89 commented Nov 19, 2020

from L70 it needs to be another job that depends on the previous one

@daviddavis daviddavis force-pushed the fix-nightly-cron-job branch 2 times, most recently from 359b1c3 to 5f8939c Compare November 24, 2020 16:47
fao89
fao89 reviewed Nov 24, 2020
View reviewed changes
templates/github/.github/workflows/nightly.yml.j2 Outdated
needs: test

env:
- TEST: docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some steps need TEST=bindings, maybe we can set it by step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some steps need TEST=bindings while others need TEST=docs. I need to either:

  1. Break these steps up into jobs each with their own before_install/install/..
  2. Rewrite the scripts. Maybe add a TEST=publish or something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on that, I would pick the easier/faster way, or maybe move the docs to publish docs workflow?

@daviddavis daviddavis marked this pull request as draft November 25, 2020 00:23
@daviddavis daviddavis force-pushed the fix-nightly-cron-job branch 15 times, most recently from 501eebc to e6dcf5f Compare November 25, 2020 21:41
@daviddavis daviddavis marked this pull request as ready for review November 25, 2020 21:42
@daviddavis daviddavis changed the title Adding matrix to nightly job Fixing the nightly job Nov 25, 2020
fao89
fao89 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@fao89 fao89 mentioned this pull request Nov 25, 2020
Merged
@fao89 fao89 merged commit 28589af into pulp:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fao89 fao89 fao89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daviddavis @pulpbot @fao89