Updating release workflow according to nightly #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
fao89
force-pushed
the
release_update
branch
2 times, most recently
from
97ba832
to
156ffac
Compare
mdellweg
reviewed
Nov 26, 2020
| @@ -76,7 +134,7 @@ jobs: | |||
| - name: Publish docs to pulpproject.org | |||
| run: bash .ci/scripts/publish_docs.sh tag $BRANCH | |||
| env: | |||
| - BRANCH=${GITHUB_REF##*/} | |||
| BRANCH: ${GITHUB_REF##*/} | |||
There was a problem hiding this comment.
I'd prefer
Suggested change
| BRANCH: ${GITHUB_REF##*/} | |
| BRANCH: ${GITHUB_REF#refs/*/} |
or even
Suggested change
| BRANCH: ${GITHUB_REF##*/} | |
| BRANCH: ${GITHUB_REF#refs/{heads,tags}/} |
Maybe the variable deserves another name now...
[noissue]
[noissue]
fao89
force-pushed
the
release_update
branch
from
422239b
to
563c257
Compare
daviddavis
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #290