This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Don't migrate importers/distributors with an empty config #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
reviewed
Oct 8, 2019
| @@ -286,14 +286,19 @@ | |||
| all are migrated. | |||
| """ | |||
| mongo_importer_q = mongo_Q(repo_id=repo.pulp2_repo_id) | |||
|
|
|||
| # importers with empty config are not needed - nothing to migrate | |||
| mongo_importer_q &= mongo_Q(config__ne={}) | |||
There was a problem hiding this comment.
it might worth adding a check if feed is null, wdyt? remotes in pulp3 are tightly coupled with the feed
ipanova
approved these changes
Oct 8, 2019
There is nothing to migrate to Pulp3 in this case. closes #5551 https://pulp.plan.io/issues/5551
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing to migrate to Pulp3 in this case.
closes #5551
https://pulp.plan.io/issues/5551