Added qpid SSL setup tasks #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochacbruno
changed the title
daviddavis
reviewed
Jul 11, 2018
| create: yes | ||
|
|
||
| - name: Create the main NSS db | ||
| command: certutil -N -d {{ tempdir }} -f {{ pwdfile }} |
There was a problem hiding this comment.
I think this is going to require --empty-password in FIPS mode as well. See: https://bugzilla.redhat.com/show_bug.cgi?id=1401606
There was a problem hiding this comment.
@daviddavis code updated, I used the empty-password and tested in f26, 27, rhel7.5 and also rhel7.5 with FIPS enabled.
rochacbruno
changed the title
omaciel
reviewed
Jul 12, 2018
|
|
||
| ## Main task | ||
|
|
||
| The main,yml tasks creates CA and sets the certificates to Apache |
omaciel
reviewed
Jul 12, 2018
|
|
||
| ## Qpid SSL | ||
|
|
||
| The qpid.yml tasks creates the qpid nss database ans sets up the certificates for |
omaciel
reviewed
Jul 12, 2018
| ca_name: "ca" | ||
| db_password: "pulp" | ||
| trust: "TCu,Cu,Tuw" | ||
| client_subject: "CN=client,O=pulp,ST=Alabama,C=US" |
- Added as a sub-task of pulp-certs role - Added handlers to restart all the services - Used `command:` module instead of openssl or certutil module - Used `blockinfile` to write config files relying on pre-existence of config files for qpid and pulp
|
@omaciel comments addressed. |
|
Thanks @rochacbruno please don't block on me :) |
|
@daviddavis @dkliban this PR is unblocked for review/merge :) |
daviddavis
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command:module instead of openssl or certutil moduleblockinfileto write config files relying on pre-existenceof config files for qpid and pulp
Pending
Tested: