Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use setuptools > 39.2.0 features in setup.py #248

Closed
evgeni opened this issue May 20, 2021 · 0 comments · Fixed by #283
Closed

Don't use setuptools > 39.2.0 features in setup.py #248

evgeni opened this issue May 20, 2021 · 0 comments · Fixed by #283
Labels
bug Something isn't working (template-set) feature request New feature request (template-set)
Milestone
0.10.0

Comments

@evgeni
Copy link
Member

evgeni commented May 20, 2021

Ohai,

currently both EL7 and EL8 ship with setuptools 39.2.0 by default, and I'd prefer not to touch such a core package of the system.

However, pulp-cli/setup.py uses find_namespace_packages which was introduced in setuptools 40.1.0. This makes it impossible to build pulp-cli from source on EL7/8 :(

Would it be possible to restrict the used featureset to what's in 39.2, so that we can build packages?
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue May 20, 2021
@mdellweg
Stop using find_namespace_packages
b5b2bf8 
This provides compatibility with older versions of setuptools.

fixes pulp#248
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue May 22, 2021
@mdellweg
Stop using find_namespace_packages
6dfc64e 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue May 22, 2021
@mdellweg
Stop using find_namespace_packages
07b10ac 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248
@mdellweg mdellweg added bug Something isn't working (template-set) feature request New feature request (template-set) triaged labels May 26, 2021
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue May 26, 2021
@mdellweg
Stop using find_namespace_packages
085dec5 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 15, 2021
@mdellweg
Stop using find_namespace_packages
c548e7f 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 28, 2021
@mdellweg
Stop using find_namespace_packages
e21d735 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 28, 2021
@mdellweg @evgeni
Stop using find_namespace_packages
888f4ae 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248

Co-authored-by: Evgeni Golov <evgeni@golov.de>
@mdellweg mdellweg mentioned this issue Jun 28, 2021
Merged
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 28, 2021
@mdellweg @evgeni
Stop using find_namespace_packages
9362e1a 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes pulp#248

Co-authored-by: Evgeni Golov <evgeni@golov.de>
mdellweg added a commit that referenced this issue Jun 29, 2021
@mdellweg @evgeni
Stop using find_namespace_packages
4975482 
Also provide the shell entrypoint in a not namespaced module.
This provides compatibility with older versions of setuptools.

fixes #248

Co-authored-by: Evgeni Golov <evgeni@golov.de>
@mdellweg mdellweg added this to the 0.10.0 milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working (template-set) feature request New feature request (template-set)
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Stop using find_namespace_packages mdellweg/pulp-cli
2 participants
@evgeni @mdellweg