Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug openapi commands #384

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Oct 3, 2021

No description provided.

@mdellweg mdellweg requested a review from ggainey October 3, 2021 15:16
@mdellweg mdellweg added this to the 0.12.0 milestone Oct 3, 2021
@mdellweg mdellweg marked this pull request as ready for review October 3, 2021 15:19
@mdellweg mdellweg force-pushed the debug_openapi branch 3 times, most recently from 36c8da7 to fa2abba Compare October 4, 2021 15:26
pulpcore/cli/common/debug.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot!

The older tests are failing because 'canceling' wasn't added to pulpcore until 0e1c62, but pulp-cli "knows about it". What can we do about that?

pulpcore/cli/common/debug.py Outdated Show resolved Hide resolved
@mdellweg
Copy link
Member Author

mdellweg commented Oct 5, 2021

@ggainey removed the jq idea for now.
Ci failure is reduced to pulp_ansible bug: pulp/pulp_ansible#659

Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

pulpcore/cli/common/debug.py Show resolved Hide resolved
@ggainey
Copy link
Contributor

ggainey commented Oct 5, 2021

@ggainey removed the jq idea for now. Ci failure is reduced to pulp_ansible bug: pulp/pulp_ansible#659

Oh - I didn't mean to ask that the jq-work be removed from here, so much as "don't do the global-option as part of this PR". But it's prob better to fully-separate the two.

Looks good - do we wait for the ansible PR to merge and a clean run before merging here?

@mdellweg mdellweg merged commit c669815 into pulp:develop Oct 5, 2021
@mdellweg mdellweg deleted the debug_openapi branch October 5, 2021 12:51
@mdellweg
Copy link
Member Author

mdellweg commented Oct 5, 2021

I don't see a reason to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants