Adjust dispatch calls to core>=3.15 interface #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #9483
mdellweg
force-pushed
the
update_dispatch
branch
from
2a55279
to
584a411
Compare
|
Attached issue: https://pulp.plan.io/issues/9483 |
ipanova
reviewed
Oct 5, 2021
| @@ -267,7 +267,7 @@ def sync(self, request, pk): | |||
|
|
|||
| result = dispatch( | |||
| sync_func, | |||
| [repository, remote], | |||
| exclusive_resources=[repository, remote], | |||
There was a problem hiding this comment.
remote can be among shared_resources.
There was a problem hiding this comment.
I drafted this to be the minimal change to unbreak master, but i can add shared_resources if desired. Not sure if it were a feature though.
ipanova
reviewed
Oct 5, 2021
| @@ -401,7 +401,7 @@ def create(self, request): | |||
|
|
|||
| config, repos = self._process_config(config) | |||
|
|
|||
| async_result = dispatch(copy_content, repos, args=[config], kwargs={}) | |||
| async_result = dispatch(copy_content, exclusive_resources=repos, args=[config], kwargs={}) | |||
There was a problem hiding this comment.
since this is a content copy operation, the source repo can be among shared_resources, _process_config should be updated so it returns 2 lists of repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes # 9483
Maybe we can declare some of the resources shared. LMK if you want to see it in this PR.