Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Containerfile for Galaxy #17

Merged
merged 1 commit into from Jun 26, 2020
Merged

Conversation

mdellweg
Copy link
Member

@pulpbot
Copy link
Member

pulpbot commented Jun 22, 2020

Attached issue: https://pulp.plan.io/issues/6713

@mdellweg
Copy link
Member Author

With this new Containerfile i was able to build and run a container that provides the galaxy login screen. @chouseknecht

How do we want to deliver this? (In a separate image, or always installed in the common image?) @bmbouter, @dkliban

Commands to reproduce:

buildah bud -f galaxy_ng/Containerfile -t pulp_galaxy_ng .
podman run --publish 8080:80 --device /dev/fuse --name pulp --volume ./settings:/etc/pulp pulp_galaxy_ng

@chouseknecht
Copy link

@mdellweg having a separate image for galaxy_ng would be pretty sweet!

@bmbouter
Copy link
Member

Thanks @chouseknecht

@mdellweg so that would be a container that ships: galaxy_ng, pulp_ansible, and pulp_contianer. Both container and ansible are dependencies of galaxy_ng. Would you be able to create that? How hard is it to auto-build-ship one of those too?

@mdellweg
Copy link
Member Author

This is exectly what the image contains. Buildshipping it is as hard as finding a proper name for it. Any suggests?

@sivel
Copy link
Contributor

sivel commented Jun 25, 2020

I've tested this by switching to the pulp-galaxy-ng image in the ansible/ansible integration tests and it is passing. See ansible/ansible#70303

@sivel
Copy link
Contributor

sivel commented Jun 26, 2020

I think we are all good with pulp/pulp-galaxy-ng.

@bmbouter
Copy link
Member

I agree, let's find a way to merge this. @mdellweg what do we need to do to merge this? I see one of the quality checks is still failing.

@mdellweg
Copy link
Member Author

I think, the build failure is due to pip19, so needs a rebase.

@mdellweg mdellweg marked this pull request as ready for review June 26, 2020 14:09
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks @mdellweg !

@mdellweg mdellweg merged commit 278d6bc into pulp:master Jun 26, 2020
@mdellweg mdellweg deleted the install_galaxy_ng branch June 26, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants