Cannot add importer to the repository.

closes #2082
https://pulp.plan.io/issues/2082

server/pulp/server/controllers/importer.py

@@ -138,8 +138,13 @@ def validate_importer_config(repo_obj, importer_type_id, config):
     :param config: configuration values for the importer
     :type  config: dict
 
+    :raises PulpCodedValidationException: if importer_type_id is invalid
     :raises exceptions.PulpDataException: if config is invalid.
     """
+    if not plugin_api.is_valid_importer(importer_type_id):
+        raise exceptions.PulpCodedValidationException(error_code=error_codes.PLP1008,
+                                                      importer_type_id=importer_type_id)
+
     importer_instance, plugin_config = plugin_api.get_importer_by_id(importer_type_id)
     call_config = PluginCallConfiguration(plugin_config, config)
     transfer_repo = repo_obj.to_transfer_repo()

server/pulp/server/webservices/views/repositories.py

@@ -338,8 +338,8 @@ def post(self, request, repo_id):
         """
         importer_type = request.body_as_json.get('importer_type_id', None)
         config = request.body_as_json.get('importer_config', None)
-        importer_controller.validate_importer_config(repo_id, importer_type, config)
         repo = model.Repository.objects.get_repo_or_missing_resource(repo_id)
+        importer_controller.validate_importer_config(repo, importer_type, config)
         async_result = importer_controller.queue_set_importer(repo, importer_type, config)
         raise exceptions.OperationPostponed(async_result)
 

server/test/unit/server/controllers/test_importer.py

@@ -254,6 +254,15 @@ def test_valid_as_expected(self, m_plug_call_config, m_repo_model, m_plug_api):
         imp_inst.validate_config.assert_called_once_with(
             m_repo.to_transfer_repo.return_value, m_plug_call_config.return_value)
 
+    @mock.patch('pulp.server.controllers.importer.PluginCallConfiguration')
+    def test_invalid_importer_type(self, m_plug_call_config, m_repo_model, m_plug_api):
+        m_repo = m_repo_model.objects.get_repo_or_missing_resource.return_value
+        m_plug_api.is_valid_importer.return_value = False
+
+        with self.assertRaises(exceptions.PulpCodedValidationException) as cm:
+            importer.validate_importer_config(m_repo, 'm_type', 'm_conf')
+        self.assertEqual(cm.exception.error_code.code, 'PLP1008')
+
 
 @mock.patch('pulp.server.controllers.importer.model')
 @mock.patch('pulp.server.controllers.importer.manager_factory')