pulp-dev.py installs and uninstalls packages. #1218
Conversation
| wish to call. | ||
| :type path_to_manage_script: basestring | ||
| """ | ||
| command = ['./manage_setup_pys.sh', 'develop'] |
There was a problem hiding this comment.
Why keep the dependency on the manage_setup_pys.sh script as opposed to having the _manage_setup_pys method perform this logic? It would seem like a win to me we could kill the manage_setup_pys.sh script entirely.
There was a problem hiding this comment.
I was on the fence about this. There are still some commands you can perform with manage_setup_pys.sh that you cannot do with this change. I'm not sure whether people use it for that or not, however. Also, I wanted to spend as little time on this right now as possible.
I'd be in favor of considering this further in the future, but for now I'd like to make this change as minimal (and quick!) as possible.
|
Seems like a really good step in the right direction. I'm not entirely sure from looking at this how a plugin writer would be able to re-use the pulp-dev.py but if the idea is to do that in a follow on PR then LGTM |
|
The plugin writer can't reuse pulp-dev.py directly, but they can import pulp.devel.environment and reuse anything that we put in there. I think we should expand this PR in the future to move a lot of the code from pulp-dev.py into this new module so that pulp-dev.py files can be simpler and less copy-pasta. |
No description provided.