This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Disable sslv3 #1245
Closed
Disable sslv3 #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,32 @@ def test_request_handles_untrusted_server_cert(self, request): | |||
|
|
|||
| @mock.patch('pulp.bindings.server.httpslib.HTTPSConnection.getresponse') | |||
| @mock.patch('pulp.bindings.server.httpslib.HTTPSConnection.request') | |||
| @mock.patch('pulp.bindings.server.SSL.Context.__init__', side_effect=server.SSL.Context.__init__, | |||
There was a problem hiding this comment.
Ah, my .vimrc was old from when we used to do 110 columns (i'm using a dev box I've not used in a while). Fixed!
|
LGTM Can you squash into one commit before merging? |
|
Yeah, I'm squashing it now. |
bowlofeggs
force-pushed
the
disable_sslv3
branch
2 times, most recently
from
40b7b0e
to
b5b2586
Compare
|
Not sure what happened with this PR, but this change was merged. |
|
This is the commit that was merged: |
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Oct 2, 2015
Includes fix that allows kombu to connect on localhost closes pulp#1245 https://pulp.plan.io/issues/1245
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still working on tests, but wanted to get this out for review.
https://bugzilla.redhat.com/show_bug.cgi?id=1153054