Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

1153344 - Allow Mongo connections over SSL. #1263

Merged
merged 1 commit into from Oct 27, 2014

Conversation

bowlofeggs
Copy link
Contributor

@bmbouter bmbouter self-assigned this Oct 24, 2014
Deprecation
-----------

- The `task_type` attribute of a `Task Report` is deprecated with Pulp 2.5.0. This attribute will be removed in a future release.
- The `task_type` attribute of a `Task Report` is deprecated with Pulp 2.5.0. This attribute will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bmbouter
Copy link
Member

Currently when you have ssl=false (the defualt) the code produces the following error:

pulp.server.db.connection:CRITICAL: Database initialization failed: ssl has not been enabled but the following ssl parameters have been set: ssl_cert_reqs, ssl_ca_certs. Please set `ssl=True` or remove.

This is because the checking for ssl settings is not conditional on the yes/no of ssl overall in logic in connection.py near lines 57-65. The default settings get passed through and on my installation of mongo that causes it not to work. Since we want default settings, we should adjust the logic to only include the other settings when ssl=true.

@bmbouter
Copy link
Member

I think 3 things should be adjusted, and then its good to merge:

  1. The logic should be adjusted so it doesn't break out with the ssl=false config (see comment above with error message).
  2. The server/pulp/server/config.py should have defaults for all values in the config
  3. The defaults from (2) should be reflected in the server.conf commented out defaults.

@bowlofeggs
Copy link
Contributor Author

I've made my fixes in response to the comments, but since there is no test coverage on our connection module I will need some time to hand test these changes before merging.

@bmbouter you are welcome to check out/try the changes as well if you like.

@bowlofeggs bowlofeggs merged commit 016ab3d into pulp:2.5-testing Oct 27, 2014
@bowlofeggs bowlofeggs deleted the 1153344 branch October 27, 2014 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants