Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

1160796 - SELinux change allowing celery to make TCP connections to all hosts and ports #1289

Merged
merged 1 commit into from Nov 6, 2014

Conversation

bmbouter
Copy link
Member

@bmbouter bmbouter commented Nov 6, 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1160796

This PR removes some portions of the SELinux policy that granted specific ports, and replaces it with a policy that grants all TCP port access to all nodes. It also adds some notes to the policy about why. These changes were also discussed on #selinux on freenode.

The BZ is about a problem accessing the proxy port, but after discussion it was determined that restricting Pulp's network access prevents normal pulp operation since sync or SMTP can be done on any port. Rather than adding another whitelist for the default proxy port, we're opening up all TCP connections. This is also OK because admins can use network or host firewalls to guard against unwanted network traffic.

I compiled this on EL6, EL7, FC19, and FC20 to ensure it will compile without error.

I also smoke tested repo create/sync/delete and consumer register/bind/update/unbind/unregister on EL6 with SELinux in enforcing mode and everything worked for me.

@mhrivnak
Copy link
Contributor

mhrivnak commented Nov 6, 2014

My expertise isn't strong enough to verify that this is correct, but it does look reasonable. It conceptually matches my expectations, and I have confidence that you implemented it correctly. :)

LGTM

bmbouter added a commit that referenced this pull request Nov 6, 2014
1160796 - SELinux change allowing celery to make TCP connections to all hosts and ports
@bmbouter bmbouter merged commit b6e36a6 into pulp:2.5-testing Nov 6, 2014
@bmbouter bmbouter deleted the 1160796 branch November 6, 2014 16:37
seandst pushed a commit to seandst/pulp that referenced this pull request Feb 11, 2016
Also resurrected a bunch of unit tests for the install distributor that had
been removed during the mongoengine conversion.

fixes pulp#1289
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants