Introducing permissions view. #1635
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
ipanova
force-pushed
the
permissions-django
branch
from
f00c3f7
to
0785c2d
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
@ipanova I looked at all the fpastes and they all look good except for this one: http://fpaste.org/184301/23669940/ This one seems to have the same extra slash problem with _href similar to the other code that uses that redirect helper function. Fixing it in the helper function would probably be good so that one fix fixes all of these cases. |
|
flake8 looks good, test coverage is 100% and they pass on all platforms. |
|
|
||
| :param request: WSGI request object | ||
| :type request: django.core.handlers.wsgi.WSGIRequest | ||
| :return: Response containing a list of permissions for resource/s |
There was a problem hiding this comment.
I'll suggest an extra line of whitespace between the return params (:return, :rtype) and the argument params for readability. Not required, but a stylistic suggestion.
|
The tests look like the mock things well, good job. |
|
@ipanova I'm done with this so I am assigning it back to you. The only issue that really needs fixing is the extra-slash regression issue. |
|
@bmbouter I looked closer to the extra slash issue - seems like that in the curl I provided url with extra slash. So the problem is not in the redirect helper function, because here i do not even use it, but in the typo during the input. Here the right example http://fpaste.org/184587/14237336/ |
ipanova
force-pushed
the
permissions-django
branch
from
0785c2d
to
8600773
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
ok test |
|
Refer to this link for build results (access rights to CI server needed): |
Adding kombu patch for reconnect issue. Patch is from celery/kombu#569 re pulp#1635 https://pulp.plan.io/issues/1635
GET /pulp/api/v2/permissions/ http://fpaste.org/184277/42366756/
GET /pulp/api/v2/permissions for particular resource http://fpaste.org/184276/42366749/
POST /pulp/api/v2/permissions/actions/grant_to_user/ http://fpaste.org/184289/14236692/
POST /pulp/api/v2/permissions/actions/grant_to_role/ http://fpaste.org/184292/36693731/
POST /pulp/api/v2/permissions/actions/revoke_from_role/ http://fpaste.org/184297/69689142/
POST /pulp/api/v2/permissions/actions/revoke_from_user/ http://fpaste.org/184298/23669796/
POST invalid params /pulp/api/v2/permissions/actions/revoke_from_user/ http://fpaste.org/184301/23669940/ (rest of the cases are the same)