This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
parse filters json only if filters are present #1919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
force-pushed
the
1040
branch
3 times, most recently
from
cfea091
to
8ec959f
Compare
asmacdo
changed the title
| mock_parse.return_value = ('mock', 'tuple') | ||
| search_view = search.SearchView() | ||
| mock_request = mock.MagicMock() | ||
| mock_request.GET = {} |
There was a problem hiding this comment.
subtle difference, but I'd use a QueryDict here, because why not?
|
I'm not sure this is the right solution. I can't find that we document anywhere that this is required, but I can think of ways this API is useful without using filters (pagination for example). If you do think it's a good idea to make this a requirement, please elaborate on why. |
asmacdo
force-pushed
the
1040
branch
2 times, most recently
from
cfd700f
to
0b31b57
Compare
asmacdo
changed the title
|
@mhrivnak, I agree with you. updated. |
fixes: 1040
|
ok test |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 7 lines...]Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1919/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1919/merge^{commit} # timeout=10Checking out Revision ec87bdb (refs/remotes/origin/pr/1919/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f ec87bdb > git rev-list ec87bdb # timeout=10Triggering rhel5-npTriggering f20-npTriggering rhel7-npTriggering rhel6-npTriggering f21-nprhel5-np completed with result SUCCESSf20-np completed with result FAILURErhel7-np completed with result SUCCESSrhel6-np completed with result SUCCESSf21-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 secondSetting status of 023c106 to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/913/ and message: Merged build finished.Test FAILed. |
|
ok test |
| mock_parse.return_value = ({'mock': 'query'}, 'tuple') | ||
| search_view = search.SearchView() | ||
| mock_request = mock.MagicMock() | ||
| mock_request.GET = {'filters': 'invalid json'} |
There was a problem hiding this comment.
I'd use a QueryDict here for authenticity. It might not make much difference, but we may as well keep tests as close to real circumstances as we can.
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 7 lines...]Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1919/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1919/merge^{commit} # timeout=10Checking out Revision ec87bdb (refs/remotes/origin/pr/1919/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f ec87bdb > git rev-list ec87bdb # timeout=10Triggering rhel5-npTriggering f20-npTriggering rhel7-npTriggering rhel6-npTriggering f21-nprhel5-np completed with result SUCCESSf20-np completed with result FAILURErhel7-np completed with result SUCCESSrhel6-np completed with result SUCCESSf21-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 secondSetting status of 023c106 to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/914/ and message: Merged build finished.Test FAILed. |
|
moving to 2.7-testing #1923 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ches
fixes: 1040
https://pulp.plan.io/issues/1040