Fixing get, update, delete call when non existent importer is provided. #1961
Conversation
| repo_query_manager = manager_factory.repo_query_manager() | ||
| repo = repo_query_manager.find_by_id(repo_id) | ||
| if repo is None: | ||
| raise pulp_exceptions.MissingResource(repo_id=repo_id) |
There was a problem hiding this comment.
This works here but will fail when merging to master because of my recent mongoengine change. Here is what you will need to do in master (replacing the previous 4 lines):
from pulp.server.db import model
model.Repository.objects.get_repo_or_missing_resource(repo_id)
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -121,6 +121,35 @@ def _process_repos(repos, details, importers, distributors): | |||
| return repos | |||
|
|
|||
|
|
|||
| def _validate_repo_importer_existance(repo_id, importer_id): | |||
There was a problem hiding this comment.
With a name like this, I do not expect it to return the importer. Perhaps this should be _get_importer or something similar. I think it is reasonable that this function could both retrieve and validate.
|
@ipanova, one minor thing, but I think it is ready. The merge forward will be more involved than normal due to some of my recent changes, let me know if I can help. |
|
Refer to this link for build results (access rights to CI server needed): |
closes #750
https://pulp.plan.io/issues/750
All this three calls behave the same:
if a non_exitent_importer provided in the call, but the repo itself exists a 404 missing_resource repo_id will be raised, though the repo exists.
Now with the fix it will return 404 missing_resource importer_id