This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
import unittest2 in compat module #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
| @check_builtin(pkgutil) | ||
| def iter_modules(*args, **kwargs): | ||
| return backports.pkgutil.iter_modules(*args, **kwargs) | ||
|
|
||
|
|
There was a problem hiding this comment.
maybe write a comment like previous imports have? this provides unittest
asmacdo
added a commit
that referenced
this pull request
Jul 7, 2015
import unittest2 in compat module
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Aug 1, 2016
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Aug 1, 2016
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Aug 1, 2016
Also removes extraneous code from rsync. re pulp#1887 https://pulp.plan.io/issues/1887 re pulp#1963 https://pulp.plan.io/issues/1963 re pulp#1759 https://pulp.plan.io/issues/1759
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Aug 1, 2016
Also removes extraneous code from rsync. re pulp#1887 https://pulp.plan.io/issues/1887 re pulp#1963 https://pulp.plan.io/issues/1963 re pulp#1759 https://pulp.plan.io/issues/1759
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use new things like
self.assertDictEqual, we are increasingly using unittest2 in older versions of python. By moving this import to the compat module, we can avoid doing this same import magic in every test module.