This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Fixes mongoengine model usage that did not have kwargs #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to mongoengine 0.9.0 revealed that parts of the Pulp codebase which used mongoengine models did not specify kwargs. This raises an exception (as it should) in mongoengine 0.9.0. I audited the existing models on 2.7-testing, fixed those, and I updated the tests to match. re pulp#934 https://pulp.plan.io/issues/934
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 5 lines...]Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/pulp/pulp.git # timeout=10Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1964/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1964/merge^{commit} # timeout=10Checking out Revision 6393b2385fa71c4aeebac1d99cb0ef0165789824 (refs/remotes/origin/pr/1964/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 6393b2385fa71c4aeebac1d99cb0ef0165789824First time build. Skipping changelog.Triggering rhel5-npTriggering rhel7-npTriggering rhel6-npTriggering f21-nprhel5-np completed with result SUCCESSrhel7-np completed with result FAILURErhel6-np completed with result FAILUREf21-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 secondSetting status of b5f2daf to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/1032/ and message: Merged build finished.Test FAILed. |
|
ok test |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 5 lines...]Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/pulp/pulp.git # timeout=10Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1964/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1964/merge^{commit} # timeout=10Checking out Revision 6393b2385fa71c4aeebac1d99cb0ef0165789824 (refs/remotes/origin/pr/1964/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 6393b2385fa71c4aeebac1d99cb0ef0165789824First time build. Skipping changelog.Triggering rhel5-npTriggering rhel7-npTriggering rhel6-npTriggering f21-nprhel5-np completed with result SUCCESSrhel7-np completed with result FAILURErhel6-np completed with result FAILUREf21-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 secondSetting status of b5f2daf to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/1033/ and message: Merged build finished.Test FAILed. |
|
ok test |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 5 lines...]Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/pulp/pulp.git # timeout=10Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1964/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1964/merge^{commit} # timeout=10Checking out Revision 6393b2385fa71c4aeebac1d99cb0ef0165789824 (refs/remotes/origin/pr/1964/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 6393b2385fa71c4aeebac1d99cb0ef0165789824First time build. Skipping changelog.Triggering rhel5-npTriggering rhel7-npTriggering rhel6-npTriggering f21-nprhel5-np completed with result SUCCESSrhel7-np completed with result FAILURErhel6-np completed with result FAILUREf21-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 secondSetting status of b5f2daf to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/1035/ and message: Merged build finished.Test FAILed. |
|
ok test |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 5 lines...]Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/pulp/pulp.git # timeout=10Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1964/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1964/merge^{commit} # timeout=10Checking out Revision 6393b2385fa71c4aeebac1d99cb0ef0165789824 (refs/remotes/origin/pr/1964/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 6393b2385fa71c4aeebac1d99cb0ef0165789824First time build. Skipping changelog.Triggering rhel5-npTriggering rhel7-npTriggering rhel6-npTriggering f21-nprhel5-np completed with result SUCCESSrhel7-np completed with result FAILURErhel6-np completed with result FAILUREf21-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 secondSetting status of b5f2daf to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/1036/ and message: Merged build finished.Test FAILed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to mongoengine 0.9.0 revealed that parts of the
Pulp codebase which used mongoengine models did not specify
kwargs. This raises an exception (as it should) in mongoengine
0.9.0.
I audited the existing models on 2.7-testing, fixed those, and
I updated the tests to match.
re #934
https://pulp.plan.io/issues/934