This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Adds logging if Pulp is missing critical Celery services #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
| elif worker['name'].startswith(SCHEDULER_WORKER_NAME): | ||
| scheduler_count = scheduler_count + 1 | ||
| elif worker['name'].startswith(RESOURCE_MANAGER_WORKER_NAME): | ||
| resource_manager_count = resource_manager_count + 1 |
There was a problem hiding this comment.
It may be worthwhile to add a debug-level logging statement here for total number of schedulers and resource managers.
There was a problem hiding this comment.
This is a good idea; I'm doing it and an associated test.
|
LGTM but I would not mind a second review since it's for 2.6.x 🐨 |
| """ | ||
| msg = _('Looking for workers missing for more than %s seconds') % self.WORKER_TIMEOUT_SECONDS | ||
| msg = _('Checking if pulp_workers, pulp_celerybeat, or pulp_resource_manager ' | ||
| 'processes are missing for more than %s seconds') % self.CELERY_TIMEOUT_SECONDS |
There was a problem hiding this comment.
python is very forgiving, but in theory this should be %d
bmbouter
force-pushed
the
1115-northern-english-brown-ale
branch
from
b7072f3
to
21eaaea
Compare
|
Refer to this link for build results (access rights to CI server needed): |
bmbouter
added a commit
that referenced
this pull request
Jul 21, 2015
Adds logging if Pulp is missing critical Celery services
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Jan 15, 2017
…nested directories Solution: Enable RSyncFastForwardUnitPublishStep to publish the same type of units into different directories by extracting the publish path of a unit from it's symlink location. re pulp#1976 https://pulp.plan.io/issues/1976
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Jan 15, 2017
Solution: Enable RSyncFastForwardUnitPublishStep to publish the same type of units into different directories by extracting the publish path of a unit from it's symlink location. This problem was introduced when the yum distributor was modified to publish repositories with a new layout. This patch makes the RPM rsync distributor consistent with the yum distributor. re pulp#1976 https://pulp.plan.io/issues/1976
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Jan 16, 2017
Solution: Enable RSyncFastForwardUnitPublishStep to publish the same type of units into different directories by extracting the publish path of a unit from it's symlink location. This problem was introduced when the yum distributor was modified to publish repositories with a new layout. This patch makes the RPM rsync distributor consistent with the yum distributor. re pulp#1976 https://pulp.plan.io/issues/1976
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/1115
closes 1115