Adds support for write concern #2081

dkliban · 2015-09-28T16:38:10Z

Pulp now accepts a write concern for the MongoDB connection. All writes
to the database are now acknowledged. For replica sets, 'majority' or 'all'
members can be asked to acknowledge the write.

pulpbot · 2015-09-28T17:07:30Z

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/1397/

bowlofeggs · 2015-09-28T20:09:53Z

docs/user-guide/release-notes/2.7.x.rst

@@ -52,6 +52,10 @@ New Features
 * Pulp properly connects to MongoDB replica sets. The `replica_set` setting in `database` section
  of `/etc/pulp/server.conf` must be provided for Pulp to connect to a replica set.

+* Pulp allows user to specify the write concern for MongoDB connection. The two options are


s/user/users/

s/for/for the/

bowlofeggs · 2015-09-28T20:19:54Z

A few things to fix, and I'll re-review:

We need to raise an Exception if the user is using mongo 2.4 and sets write concern without a replica set.
We need unit tests that test all the cases, success and error. These tests didn't assert normal cases (mongo 2.4 with replica set, mongo 2.6 with replica set, mongo 2.6 without replica set, for example.)
The test assertions need to be stronger. These tests only assert that an error was raised, but not that it was the correct error.

dkliban · 2015-09-30T18:35:01Z

@rbarlow If a user is using Mongo 2.4, he does not have to use a replica set. Our default of 'majority' does not work without using a replica set. However, when MongoDB is running in single node mode, a write concern of 1 behaves the same way in MongoDB 2.4 as 'majority' in MongoDB 2.6.

bowlofeggs · 2015-10-01T19:06:33Z

ok test

dkliban · 2015-10-02T15:40:53Z

ok test

pulpbot · 2015-10-02T15:48:16Z

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/1414/

mhrivnak · 2015-10-05T19:20:48Z

common/pulp/common/error_codes.py

@@ -100,6 +100,9 @@
 PLP0041 = Error("PLP0041", _("Database 'replica_set' config must be specified when more than one "
                             "seed is provided. Refer to /etc/pulp/server.conf for proper use."),
                [])
+PLP0043 = Error("PLP0043", _("Database 'write_concern' config can only be 'majority' or 'all'. "


why not 42?

@mhrivnak Because we already have 42 on master

pulpbot · 2015-10-06T18:37:40Z

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/1434/

dkliban · 2015-10-06T20:05:00Z

ok test

pulpbot · 2015-10-06T20:12:01Z

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/1439/

mhrivnak · 2015-10-06T20:20:34Z

server/pulp/server/db/connection.py

            if len(seeds_list) > 1 and not replica_set:
                raise PulpCodedException(error_code=error_codes.PLP0041)
            while True:
                _CONNECTION = _connect_to_one_of_seeds(connection_kwargs, seeds_list, name)
                if _CONNECTION:
+                    db_version = semantic_version.Version(_CONNECTION.server_info()['version'])
+                    if cmp(db_version, MONGO_MINIMUM_VERSION) == -1:


I think this (and below) would be more readable with normal comparison operators, which you can use with these objects (unless you found some edge case?). I suggest

db_version < MONGO_MINIMUM_VERSION

dkliban · 2015-10-07T13:16:45Z

ok test

pulpbot · 2015-10-07T13:22:00Z

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/1442/

mhrivnak · 2015-10-07T13:32:23Z

server/test/unit/server/db/test_connection.py

@@ -1,18 +1,23 @@
-import unittest
+import unittest, unittest2


last comment, I swear. ;) unittest2 is a third-party module, so it should be in the second group of imports.

Pulp now accepts a write concern for the MongoDB connection. All writes to the database are now acknowledged. For replica sets, 'majority' or 'all' members can be asked to acknowledge the write. closes: pulp#974 closes: pulp#1139

dkliban · 2015-10-07T13:42:49Z

ok test

pulpbot · 2015-10-07T13:47:58Z

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/1444/

Adds support for write concern

closes pulp#2081 https://pulp.plan.io/issues/2081

…nt changes Updates a particular distributor's last published timestamp closes pulp#2081 https://pulp.plan.io/issues/2081 (cherry picked from commit deabcbc)

dkliban force-pushed the write_concern branch from a6e4b0b to 38ec2e3 Compare September 28, 2015 16:59

bowlofeggs reviewed Sep 28, 2015
View reviewed changes

bowlofeggs assigned dkliban Sep 28, 2015

dkliban force-pushed the write_concern branch from 38ec2e3 to afe452d Compare October 1, 2015 14:27

bowlofeggs assigned bowlofeggs and unassigned dkliban Oct 1, 2015

mhrivnak reviewed Oct 5, 2015
View reviewed changes

mhrivnak assigned dkliban and unassigned bowlofeggs Oct 5, 2015

dkliban force-pushed the write_concern branch from 70a867d to 1d90eec Compare October 6, 2015 18:33

dkliban self-assigned this Oct 6, 2015

dkliban force-pushed the write_concern branch from ad96d67 to b47474e Compare October 6, 2015 20:00

dkliban assigned mhrivnak and unassigned dkliban Oct 6, 2015

mhrivnak reviewed Oct 6, 2015
View reviewed changes

mhrivnak assigned dkliban and unassigned mhrivnak Oct 6, 2015

dkliban force-pushed the write_concern branch from b47474e to 415a90c Compare October 7, 2015 12:56

dkliban assigned mhrivnak and unassigned dkliban Oct 7, 2015

mhrivnak reviewed Oct 7, 2015
View reviewed changes

mhrivnak added the LGTM label Oct 7, 2015

mhrivnak assigned dkliban and unassigned mhrivnak Oct 7, 2015

Adds support for write concern

1ad3644

Pulp now accepts a write concern for the MongoDB connection. All writes to the database are now acknowledged. For replica sets, 'majority' or 'all' members can be asked to acknowledge the write. closes: pulp#974 closes: pulp#1139

dkliban force-pushed the write_concern branch from 415a90c to 1ad3644 Compare October 7, 2015 13:38

dkliban added a commit that referenced this pull request Oct 7, 2015

Merge pull request #2081 from dkliban/write_concern

15e9277

Adds support for write concern

dkliban merged commit 15e9277 into pulp:2.7-testing Oct 7, 2015

dkliban added a commit to dkliban/pulp that referenced this pull request Jul 15, 2016

Updates a particular distributor's last published timestamp

deabcbc

closes pulp#2081 https://pulp.plan.io/issues/2081

This was referenced Jul 15, 2016

Updates a particular distributor's last published timestamp #2640

Closed

Updates a particular distributor's last published timestamp #2641

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for write concern #2081

Adds support for write concern #2081

dkliban commented Sep 28, 2015

pulpbot commented Sep 28, 2015

bowlofeggs Sep 28, 2015

bowlofeggs Sep 28, 2015

bowlofeggs commented Sep 28, 2015

dkliban commented Sep 30, 2015

bowlofeggs commented Oct 1, 2015

dkliban commented Oct 2, 2015

pulpbot commented Oct 2, 2015

mhrivnak Oct 5, 2015

dkliban Oct 5, 2015

pulpbot commented Oct 6, 2015

dkliban commented Oct 6, 2015

pulpbot commented Oct 6, 2015

mhrivnak Oct 6, 2015

dkliban commented Oct 7, 2015

pulpbot commented Oct 7, 2015

mhrivnak Oct 7, 2015

dkliban commented Oct 7, 2015

pulpbot commented Oct 7, 2015

Adds support for write concern #2081

Adds support for write concern #2081

Conversation

dkliban commented Sep 28, 2015

pulpbot commented Sep 28, 2015

bowlofeggs Sep 28, 2015

Choose a reason for hiding this comment

bowlofeggs Sep 28, 2015

Choose a reason for hiding this comment

bowlofeggs commented Sep 28, 2015

dkliban commented Sep 30, 2015

bowlofeggs commented Oct 1, 2015

dkliban commented Oct 2, 2015

pulpbot commented Oct 2, 2015

mhrivnak Oct 5, 2015

Choose a reason for hiding this comment

dkliban Oct 5, 2015

Choose a reason for hiding this comment

pulpbot commented Oct 6, 2015

dkliban commented Oct 6, 2015

pulpbot commented Oct 6, 2015

mhrivnak Oct 6, 2015

Choose a reason for hiding this comment

dkliban commented Oct 7, 2015

pulpbot commented Oct 7, 2015

mhrivnak Oct 7, 2015

Choose a reason for hiding this comment

dkliban commented Oct 7, 2015

pulpbot commented Oct 7, 2015