server.conf is lazily loaded #2176
Conversation
|
The tests file covers the lazy loader, but also adds coverage to the previously uncovered bits toward the bottom of |
seandst
force-pushed
the
607-lazy-load-server-conf
branch
from
5ea3b29
to
b392fbb
Compare
|
Hmm. Testing this on a system where server.conf is not readable or doesn't exist still breaks the test suite because the thing that |
seandst
force-pushed
the
607-lazy-load-server-conf
branch
2 times, most recently
from
82aed3c
to
a5fe7bc
Compare
|
I thought I'd updated this, but apparently not... :( The changes I mentioned above have been made. |
|
ok test |
| config_2.write(FAKE_CONFIG_2) | ||
| config_2.close() | ||
|
|
||
| # teh spoofs (spooves?) |
There was a problem hiding this comment.
this was a bad joke, and I'm keeping it :)
There was a problem hiding this comment.
I thought it would be funny to leave a serious comment on an obvious joke, but I guess not.
|
I believe there is one test that is missing assertions, but other than that, LGTM. Really nice tests. |
seandst
force-pushed
the
607-lazy-load-server-conf
branch
from
a5fe7bc
to
3f17525
Compare
pulp.server.config would load /etc/pulp/server.conf unconditionally at import time. Converting this to lazily loading the config file allows for the config object to be instantiated without immediately trying to read the conf. This also allows changing the config files before loading them, which makes pulp.server.config testable. fixes pulp#607
seandst
force-pushed
the
607-lazy-load-server-conf
branch
from
3f17525
to
5b51621
Compare
pulp.server.config would load /etc/pulp/server.conf unconditionally at
import time. Converting this to lazily loading the config file allows
for the config object to be instantiated without immediately trying
to read the conf. This also allows changing the config files before
loading them, which makes pulp.server.config testable.
fixes #607
https://pulp.plan.io/issues/607