Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

adding UTCDateTimeField, which always returns datetimes with timezone UTC #2188

Merged
merged 1 commit into from Nov 24, 2015

Conversation

mhrivnak
Copy link
Contributor

@mhrivnak
Copy link
Contributor Author

Looks like the F23 tests are failing for unrelated reasons.

@seandst seandst added the LGTM label Nov 24, 2015
@seandst
Copy link
Contributor

seandst commented Nov 24, 2015

LGTM, because...

  • Explicit is better than implicit. (datetime objects returned by mongo are always tz-aware UTC)
  • Simple is better than complex. (we aren't messing with timezones, just one timezone)
  • In the face of ambiguity, refuse the temptation to guess. (naive datetime objects are ambiguous, tz-aware datetime objects are not)
  • There should be one-- and preferably only one --obvious way to do it. (use UTCDateTime)

:)

mhrivnak added a commit that referenced this pull request Nov 24, 2015
adding UTCDateTimeField, which always returns datetimes with timezone UTC
@mhrivnak mhrivnak merged commit 4926bc2 into pulp:master Nov 24, 2015
@mhrivnak mhrivnak deleted the utcdatetimefield branch November 24, 2015 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants