This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Allow xsendfile to serve /var/lib/pulp/content. #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,8 +11,9 @@ | |||
| from pulp.server.config import config as pulp_conf | |||
|
|
|||
|
|
|||
| # Make sure all requested paths fall under this directory. | |||
| # Make sure all requested paths fall under these directory. | |||
There was a problem hiding this comment.
I guess it should be 'under this directory' or 'under these directories' If my English knowledge does not betray me :D
There was a problem hiding this comment.
Your English knowledge has not betrayed you
When I initially tested the directory index, I used lazy and links resolved to /var/lib/pulp/published/.../. However, if the content exists, os.path.realpath follows it into /var/lib/pulp/content/. This is one of the issues blocking issue 1654.
jeremycline
force-pushed
the
allow-content-too
branch
from
72111d8
to
e74bd62
Compare
jeremycline
added a commit
that referenced
this pull request
Feb 11, 2016
Allow xsendfile to serve /var/lib/pulp/content.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I initially tested the directory index, I used lazy and links
resolved to /var/lib/pulp/published/.../. However, if the content
exists, os.path.realpath follows it into /var/lib/pulp/content/.
This is one of the issues blocking issue 1654.