Streamer download requests use permanently stored pem files. #2499
Conversation
bowlofeggs
changed the title
bowlofeggs
force-pushed
the
1771
branch
6 times, most recently
from
f8f894e
to
0573817
Compare
bowlofeggs
changed the title
| @@ -454,14 +454,17 @@ def queue_delete(repo_id): | |||
|
|
|||
| def get_importer_by_id(object_id): | |||
| """ | |||
| Get a plugin and call configuration using the document ID | |||
| Get a plugin, call configuration, and Importer document object using the document ID | |||
There was a problem hiding this comment.
I knew you would like that @jeremycline.
http://www.theonion.com/article/4-copy-editors-killed-in-ongoing-ap-style-chicago--30806
| importer_constants.KEY_SSL_CLIENT_CERT: 'Client Cert', | ||
| importer_constants.KEY_SSL_CLIENT_KEY: 'Client Key'} | ||
| importer = model.Importer(repo_id='coolcars', importer_type_id='supercar', config=config) | ||
| temp_path = tempfile.mkdtemp() |
There was a problem hiding this comment.
Somebody told me about https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory recently. Too bad we can't use Python 3.
There was a problem hiding this comment.
Haha, wasn't that me, yesterday?
There was a problem hiding this comment.
Yeah, I was trying to pour salt into the wound, but I guess my text tone was just a little off 😄
There was a problem hiding this comment.
I really wish we could use Python 3 though ☹
|
Looks good to me. I got worried for a second with the Anyway, nice job. I'm not sure why Jenkies is unhappy, but it doesn't look to be related to this PR. |
|
Yeah that change also made me nervous, but I did grep for other uses and found that only the streamer uses it. Unfortunately, there is another function with the same name in pulp.plugins.something so the grep was slightly tricky. |
This commit begins a shift towards storing repository PEM data (CA certificates, client certificates, and client keys) on the filesystem, and passing paths to those certs to Nectar rather than allowing nectar to write them in temporary files. This commit provides the infrastructure for this change, but only converts the streamer to using it. All other downloads in Pulp still take the old, now deprecated path. https://pulp.plan.io/issues/1771 fixes pulp#1771
This commit begins a shift towards storing repository PEM data (CA
certificates, client certificates, and client keys) on the
filesystem, and passing paths to those certs to Nectar rather than
allowing nectar to write them in temporary files.
This commit provides the infrastructure for this change, but only
converts the streamer to using it. All other downloads in Pulp
still take the old, now deprecated path.
https://pulp.plan.io/issues/1771
fixes #1771