This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Refactor MetadataFileContext to DRY things up #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| no checksum is added to the filename | ||
| :type checksum_type: str or None | ||
| :param no_checksum_filenames: file names that *will not* have a checksum prepended to them | ||
| :type no_checksum_filenames: list or None |
There was a problem hiding this comment.
Nitpick, but maybe name this "dont_checksum_filenames"? It's longer which is a negative, but it's more verby and maybe clearer (not that the param docs aren't clear). Feel free to ignore.
There was a problem hiding this comment.
Or dont_checksum_list maybe?
|
LGTM. All comments are optional. |
This appears to have been copied over to pulp_rpm at some point and subsequently modified to have yum-specific behavior. Behaviors that were not yum-specific and the related tests have been pushed back to platform.
seandst
added a commit
to seandst/pulp
that referenced
this pull request
Feb 6, 2017
seandst
added a commit
to seandst/pulp
that referenced
this pull request
Feb 6, 2017
seandst
added a commit
to seandst/pulp
that referenced
this pull request
Feb 6, 2017
seandst
added a commit
to seandst/pulp
that referenced
this pull request
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been copied over to pulp_rpm at some point
and subsequently modified to have yum-specific behavior. Behaviors
that were not yum-specific and the related tests have been pushed
back to platform.