This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Adds predistributor logic to the publish controller #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
force-pushed
the
rsync-predistributor
branch
from
f33e5e2
to
6fb20c6
Compare
| """ | ||
|
|
||
| r = cls(repo_id, distributor_id, distributor_type_id, started, completed, | ||
| cls.RESULT_SKIPPED) | ||
| message = 'Skipped. Nothing changed since last publish' | ||
| message = _('Skipped: %(reason)s' % {'reason': message}) |
There was a problem hiding this comment.
The variable replacement is happening before the call to _(), but it needs to happen afterwards.
|
ok test |
1 similar comment
|
ok test |
|
@dkliban I just did a round of testing against the latest and functionally it all worked. Since the test runner here is being strange I'm going to run the tests locally. |
|
All tests pass for me locally, and all comments have been addressed. I'm adding the LGTM. |
If a distributor has a predistributor_id configured, the publish is skipped when the predistributor has not published since the last publish by the distributor. This includes situations where the predistributor has not published at all. re pulp#1887 https://pulp.plan.io/issues/1887
dkliban
force-pushed
the
rsync-predistributor
branch
from
01c71be
to
01c02b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a distributor has a predistributor_id configured, the publish is skipped when the
predistributor has not published since the last publish by the distributor. This includes
situations where the predistributor has not published at all.
re #1887
https://pulp.plan.io/issues/1887