This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Fixes relabel.sh to handle empty string being passed in. #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version comparison mechanism no longer handled an empty string being passed in. As a result none of the restorecon statements were getting run at the end of pulp-selinux installation. closes pulp#2436 https://pulp.plan.io/issues/2436
|
@dkliban, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bowlofeggs and @bmbouter to be potential reviewers. |
seandst
approved these changes
Nov 23, 2016
| # Set the previous version to 0.0 if one is not passed in | ||
| if [ -z $1 ] | ||
| then | ||
| set -- "0.0" |
|
The travis failures are a result of travis trying to pep8-verify a bash script. They should be ignored. |
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 29, 2016
The problem with the first backport was that it was not entirely compatible with requests-2.6 and urllib3-1.10, which is what el6 and el7 ship.
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 29, 2016
The problem with the first backport was that it was not entirely compatible with requests-2.6 and urllib3-1.10, which is what el6 and el7 ship.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version comparison mechanism no longer handled an empty string being passed in.
As a result none of the restorecon statements were getting run at the end of pulp-selinux
installation.
closes #2436
https://pulp.plan.io/issues/2436