Add a DownloadCatalog ViewSet

[fdobrovolny]

closes #2303
https://pulp.plan.io/issues/2303

[mention-bot]

@BrnoPCmaniak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @seandst, @goosemania and @asmacdo to be potential reviewers.

[fdobrovolny]

@werwty Just letting you know I fixed the merge conflict.

[werwty]

I tried running this PR as is, and got

ImproperlyConfigured at /api/v3/downloadcatalog/

Could not resolve URL for hyperlinked relationship using view name "artifact-details". You may have failed to include the related model in your API, or incorrectly configured the `lookup_field` attribute on this field.

There's two things in the catalog serializer:

1. There is not going to be a Artifact ViewSet: https://pulp.plan.io/issues/2305#note-6
   This should be content instead
2. view_name should be plural endpoint - singular detail. In this case view_name=importers-detail

[werwty]

s/downloadcatalog/downloadcatalogs/
Endpoint names (the endpoint_name attribute) should plural, not singular [0]

[werwty]

I think the pagination should be moved to here

[pep8speaks]

Hello @BrnoPCmaniak! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 02, 2017 at 18:14 Hours UTC

[werwty]

The viewset looks good, there are some separate problems with the download catalog serializers, and I will file a redmine issue for that.

[jortel]

The DownloadCatalog has been replaced with the DeferredArtifact. Seems this work needs to be revised to be aligned with this.

This issue: 2968 removes the DownloadCatalog. Perhaps, this issue/pr could ensure that the DeferredArtifact model has a serializer and viewset?

[1] https://pulp.plan.io/issues/2968

[asmacdo]

Since this object has been replaced, I'm closing this issue.