This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
fixes #2786: Allow content application to use console logging #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehelms, thanks for your PR! By analyzing the history of the files in this pull request, we identified @asmacdo, @jortel and @daviddavis to be potential reviewers. |
|
ok test |
|
Can one of the admins verify this patch? |
|
ok test |
|
I added some polish and rebased this, which is available in this PR: #3095 We should probably get that merged, and then close this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not touched tests yet but I did include re-factoring to better centralize common validation checks of the configuration and required availability of things like the syslog path.
The context for the change is that I have created a stand alone container that runs Apache and serves up the content and repo_auth wsgi applications independent of having a Pulp server present.